CE v3 with Synology NAS PHP 8

BBloke

I can finally switch my NAS to PHP 8 and see how things are working.
I've installed a fresh copy of v3.1.11 and gotten web logins working. Took some time and I won't go into it but it works.
I've checked out my own site and found that I'm having issues with DocLister depending on whether I have a URL placeholder.

This chunk used as &tpl creates an error:

<div class="masonryGridItem [+2ColumnSpan+]">
	<h3>
		<span id="smaller" style="float:right;"> on [+date+]</span>
		<a href="[~[+id+]~]" title="[+title+]">[+longtitle+]</a><br />
	</h3>
	<p class="nl_link">Tags: [[DLItemTags? &id=`tags` &tags=`[+tags+]` &tagsLanding=`118`]]</p>
	<p class="nl_summaryText">[+summary+]</p>
	<p class="nl_link">
		<a href="[~[+id+]~]" title="[+title+]">Continue Reading</a>
	</p>
  	<div id="nl_comments_[+id+]" style="display: none;"></div>
</div>

I get the following error:

Where as removing the [~[+id+]~] allows the code to run fine.

Would anyone have any ideas?

BBloke

Haven't figured out why but changing [~[+id+]~] to [+url+] cures it. An RTFM moment!

mplavala

This is not DocLister bug, this is core Evo bug. Maybe submit a bug report to https://github.com/evocms-community/evolution

BBloke

Thanks @mplavala I'll put a bug report up on github.

BBloke

I'm finding this is quite bad. I'm not sure if there would be a config setting in PHP8 for my NAS box that would help but the issue cascades through code and really kicks the tyres.

Whilst I'm finding it difficult to understand what is happening I'll try and describe what I think is going on.

I have a pretty simple site which has two templates.
A single column and a double column.

Double:

Single:

Both have a top menu. The double column template has a section that shows the possible child menu options as well as a recent docs part. In the middle is a chunk that shows the profile/logout buttons.

My home page works, which has a simple DocLister call to show child docs.

Another page, Tutorials, works as expect too (id: 119).
If I click the child page: EvoCMS (ID 138) I get this error!

The 119 if refers to is the parent ID.

I've tracked it down to a chunk I have which shows the Profile and Logout buttons.

<div id="wlpeUser">
	<fieldset id="wlpeUserButtons">
		<a class="button" href="[~103~]" title="profile">Profile</a>
		[[if? &is=`[*Login*]:is:Logout` &then=`<a class="button btn btn-primary" href="[~[*id*]~]?logout">Logout</a>` &else=`<a class="button btn btn-primary" href="[~4~]">Login</a>` ]]
	</fieldset>
</div>

removing the url placeholder removes the error!

<div id="wlpeUser">
	<fieldset id="wlpeUserButtons">
		<a class="button" href="[~103~]" title="profile">Profile</a>
		[[if? &is=`[*Login*]:is:Logout` &then=`<a class="button btn btn-primary" href="?logout">Logout</a>` &else=`<a class="button btn btn-primary" href="[~4~]">Login</a>` ]]
	</fieldset>
</div>

Basically, any chunk within a template or page the has [id] (or [+id+] with DocLister) throws an error!

mplavala

BarnsleyBloke This still seems as the same core error. I look like the construction [~[*id*]~] does not work as it should. But the good news is that this seems to be the same bug as before. Hopefully it gets resolved soon.

user451

none of the template variable calls work! i have a evo1.4.18 working on php8 now but i had to replace everything with a snippet call.

normal templates variables don't work [page-right-aligned-image2] . make a snippet to get the value directly. this editor is removing the asterix which is on either side of ""page-right-aligned-image2""
these don't work src="[₃₃]" . make a snippet to make the link. this editor is removing the #tilda# which is supposed to be on either side of that ""33"".
these don't work [pagetitle] and [content] . make a snippet to get the value. this editor is removing the asterix which is on either side of ""pagetitle"" and ""content"" above.

when did all of these stop working? this is the parsing that is special to evo and modx: snippet, chunk, template-variable etc. this is the EVO PARSER that sees [-TILDA-33-TILDA-] and knows that he needs to make a link to document id 33.

BBloke

Pathologic gave some time to have a look at my case and fix the issue.

My NAS box is now on php8 and I have some legacy sites I'm slowly trying to convert.

I haven't come across the same on v1.4 (yet) but if the same issue persists then it hopefully is an easy fix.

What did come out of yesterday whilst I was testing things. Everything worked when friendly URLs were off.

Pathologic confirmed it had something to do with full aliasing.