PHP8 and EVO 3.x plugin error messages "fix"

fourroses666

I seem to have issues when I use PHP 8 and plugins TemplatesEdit3 / MultiTV.
The only dirty fix I found is to go to Configuration and set [(error_reporting)] Ignore all and it works again.

I understand this is not the best fix but it works.
( I just couldn't understand why it worked on a site while it didn't on an other one with the same plugins etc. but different warning setting )

EDIT

Its fixed

BBloke

I found there are warnings and errors. My php8 is set to display warnings so I see the warnings you normally wouldn't but errors, I always try and figure out.

Evo plugin and snippet warnings are the worst when it is coded in the database but I have figured that it does give you the line number and applicable plugin so they are reasonably easy to track down.

I've pretty much corrected all the plugins I use (hopefully) but those I don't use.

Happy to have a look and help if you need it.

esebob

BarnsleyBloke did you happen to change the visibility of __wake() to public? That was an error I got with doclister, but not sure if it is a good thing to do..

BBloke

I installed templatesEdit3 and it hasn't thrown an error yet. I'm on XAMPP 8.1.2.

I haven't changed anything relating to functions. It's always been inside the them that's needed attention.

Where would I find __wake()?

I did download DocLister from github and installed the latest just in case.

cimt67

Hi Marc,
i had this error (templatesedit3):
Undefined array key "caption" ... line 261 in file ".../class/templateseditbuilder.class.php".

I have line 261:
'title' => $v['caption'],
replaced it with this:
'title' => $v['caption'] ?? '',
and it works

Clean installation of Evolution CE 3.1.12
PHP 8.0 and 8.1

I have seen how Pathologic has fixed: multiTV here: [https://github.com/extras-evolution/multiTV/commit/cc0fc838362cef0d6d55b0f61d7558e7d94ce027]

and adopted it like this for templatesedit. But I am not sure if its correct!

BBloke

That's what I would have done. So nothing wrong with the fix.

fourroses666

Going to check soon. Thanks for the heads up!

fourroses666

TemplateEdit3 fix seem to work.
As for MultiTV I get a new error;

strlen(): Passing null to parameter #1 ($string) of type string is deprecated
« Evolution CMS Parse Error »

Error : Undefined array key "width"

Error information 	
ErrorType[num] 	WARNING[2]
File 	/home/???/domains/???.nl/public_html/assets/tvs/multitv/includes/multitv.class.php
Line 	527
Source 	if ($this->fields[$fieldname]['width']) {

When changing the config;

$settings['fields'] = array(
	'title' => array(
                'caption' => 'Titel',
                'type' => 'text',
                'width' => '100%'
            ),

But that's not really I would like to add to all fields

BBloke

I would change it to:

if (!empty($this->fields[$fieldname]['width'])) {

The strlen message I think relates to 'includes/phx.parser.class.inc.php'
Lines 253 and 371:

Not sure what the fix would be for that!

cimt67

BarnsleyBloke
Yes, your solution is correct... I think "Undefined array key" will keep us busy for a while yet 😅

BBloke

I managed to get an error with out multiTV. I've posted it up on github! https://github.com/evocms-community/evolution/issues/132

fourroses666

Cool guys, its fixed for both plugins.

https://github.com/extras-evolution/multiTV/commit/da32700729f462f0f57508ac8a847c1fafdcd5d6
https://github.com/64j/templatesedit3/commit/71ae0736a48eebba07f06e521268264afe79a563